Conversation
Refs constructorfabric#235 Signed-off-by: Aleksandr Barkhatov <pm@aleks.bar> (cherry picked from commit 485e60b)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of
485e60b("refactor: remove legacy metric UI and its dead layers", main via #236, refs #235) ontorelease-2026.07.1.Why
On the release branch the sidebar still shows the New design switch, so the legacy metric UI is reachable even though the new UI is already default-on (
8c79c8e). This commit is the one that takes the toggle away onmain— it drops the switch together with the legacy screens and the dead data layers behind them.What changes
New designtoggle:sidebar-v2-settings.tsxandsrc/lib/feature-flags.tsare gone, replaced bysidebar-settings.tsx(focus mode + explanations only).widgets/*,src/api/{transforms,catalog-client,view-configs,metric-semantics,...}, legacy queries and mock factories.engineering-dashboard-v2→dashboard,queries/v2/member-grid→queries/member-grid,lib/insight/v2/peer-status→lib/insight/peer-status).cypilot/config/artifacts.toml, nginx/docker-entrypoint touch-ups, dependency trims inpackage.json/pnpm-lock.yaml.197 files changed, +774 / −19,856. Cherry-picked with
-x; no conflicts.Verification
pnpm typecheck— cleanpnpm exec eslint src --max-warnings 0— cleanpnpm test— 73 files, 415 tests passingpnpm build— succeeds