ci: make typecheck job actually type-check the project

[aleksdotbar]

Problem

The CI typecheck job ran tsc --noEmit. In non-build mode, tsc does not follow project references, and the root tsconfig.json declares "files": []. Result: the command type-checks zero files and exits 0 regardless of type errors anywhere in src.

Every type error since this config landed was invisible to CI — caught only by a developer running tsc -b locally (via pnpm build). This is how type-breaking changes have reached main green (e.g. the missing csrfToken Session fixtures fixed in #216).

Proof

Injecting const x: number = "s" into src/auth/types.ts:

• tsc --noEmit (old CI command) → exit 0, error missed
• tsc -b (build) → exit 2, error caught

tsc --noEmit --listFiles loads 0 files from src.

Fix

typecheck → tsc -b, so the job type-checks the same project graph as the build. noEmit: true in tsconfig.app.json keeps it emit-free.

🤖 Generated with Claude Code

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

Authentication test alignment

Layer / File(s)	Summary
Typecheck command package.json	The typecheck script now runs tsc -b.
CSRF-aware authenticated fixtures src/api/*.test.*, src/auth/use-viewer.test.ts, src/components/auth-gate.test.tsx, src/components/widgets/v2/*.test.tsx	Authenticated test state now includes csrfToken: "csrf-1" across API, auth, and widget tests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: cyberantonz

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: updating CI typecheck behavior to actually check the project.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ci-typecheck-build-mode

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}