fix(team-view): show a member's full metric set in the details sheet - #193
Conversation
The member details sheet was capped at the heatmap's 7 hardcoded COLUMNS, dropping the rest of the per-person data already in memory (constructorfabric/insight#1729). The sheet now shows the grid cells first, then the remaining legacy bullets (colored vs the member's own department cohort), then the unified-path (git/ai) entries built via buildPeerStoryEntries from the per-person metric-results the screen already fetches. Sources a grid column already covers are deduped by metric key, dot-suffix (git.prs_merged ~ prs_merged) and label. MemberDetailRow now carries preformatted display strings so legacy bullets and unified metrics can share the sheet rendering. Wiki is still not fetched per member (no member-values metric on either path) and stays out of the sheet. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Roman Mitasov <roman.mitasov@constructor.tech>
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…from Expand details In the Members × metrics popup, "Open in IC view" opened the details sheet while "Expand details" toggled an inline bullet strip under the row. Rework per review of #198: "Open in IC view" is now a router link to the member's personal IC page, and "Expand details" opens the details sheet (which already shows the full metric set after #193). The inline ExpandedBullets strip and its expansion state go away. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Roman Mitasov <roman.mitasov@constructor.tech>
…he IC page (#200) * Revert "fix(team-view): grow Members × metrics grid columns to the full metric set (#198)" This reverts commit 1a44492. Signed-off-by: Roman Mitasov <roman.mitasov@constructor.tech> * fix(team-view): link the member popup to the IC page, open the sheet from Expand details In the Members × metrics popup, "Open in IC view" opened the details sheet while "Expand details" toggled an inline bullet strip under the row. Rework per review of #198: "Open in IC view" is now a router link to the member's personal IC page, and "Expand details" opens the details sheet (which already shows the full metric set after #193). The inline ExpandedBullets strip and its expansion state go away. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Roman Mitasov <roman.mitasov@constructor.tech> --------- Signed-off-by: Roman Mitasov <roman.mitasov@constructor.tech> Co-authored-by: Roman Mitasov <roman.mitasov@constructor.tech> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Fixes constructorfabric/insight#1729
Problem
Clicking a member row on the Team dashboard opened a details sheet that showed only the heatmap's 7 hardcoded
COLUMNS, even though the wider per-person data was already fetched and in memory.Change
members-heatmap/index.tsx): sheet rows are now grid cells first, then the remaining legacy bullets (status/median vs the member's own department cohort, same machinery as the grid), then unified-path (git/ai) entries. Sources a grid column already covers are deduped by metric key, dot-suffix (git.prs_merged≈prs_merged) and label.team-view-v2.tsx→ newmemberMetricEntriesinlib/insight/team-metrics.ts): per-personPeerStoryEntrylists are built from the/v1/metric-resultsdata the screen already fetches forgit_outputandai_adoption(each entry's status is vs the person's own org unit via the peer view) and passed to the heatmap for the sheet.MemberDetailRowreshaped to carry preformatted display strings, so legacy bullets (transform-formatted) and unified metrics (formatMetricValue) share the sheet rendering, keyed by metric key instead of label.Out of scope
wikiis still not fetched per member on either path (no member-values metric), so its metrics stay out of the sheet — noted in the issue.Tests
members-heatmap/index.test.tsx: opens the sheet end-to-end and asserts bullets beyond the 7 columns and unified entries render, bucketed by status, with column-covered twins deduped.team-metrics.test.ts:memberMetricEntrieskeying, own-cohort statuses, unresolved-group behavior.🤖 Generated with Claude Code