Add support to avoid overwriting trained models #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will think about how this interacts with continuing training from an existing checkpoint. |
|
Hi @constantinpape, I took care of interactions between continuing training with overwriting trained models (i.e. raising error when GTG from my side! |
constantinpape
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional support to the
DefaultTrainerin favor of avoiding to train if the training is already completed. This is controlled via thefitmethod with theoverwrite_trainingargument, which is set toTrueas default (i.e. the current action of the trainers). If this is set toFalse, it will check in thelatest.ptcheckpoint to verify if the training is finished or not. GTG from my side!