-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignorelist to pack command. #964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, address / answer two minor concerns & this should be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice before, but it looks like you hand-modified the Archive.md file, which is a generated file. To update the documentation in a persistent way, add the new instructions to the top of the file (e.g. Pack.php) and run ./robo docs
to re-generate the documentation.
Ok, I fix the doc by adding the correct comments and running |
It's usually better to not rewrite history in a PR; I always squash-and-merge when done anyway. This PR is short enough that it wasn't an issue, though. Thank you for contributing this. |
Overview
This pull request:
Summary
Related to #961, allows to filter patterns when creating an archive.
Description
Files or folders could be excluded by using patterns, it's a good way to clean your package before delivery without touching you project folder tree.
Good to know :
Zip allows regexp, glob or string, @see https://symfony.com/doc/current/components/finder.html#file-name.
Tar, gz and bz2 allow only regexp @see https://pear.php.net/package/Archive_Tar/docs/latest/Archive_Tar/Archive_Tar.html#methodsetIgnoreList.