Skip to content

Set timeout for fail gracefully #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ish1301 wants to merge 2 commits into from
Closed

Set timeout for fail gracefully #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbc439f
Set timeout for fail gracefully
ish1301 Sep 12, 2017
ee15045
Use timeout config in curl client
iskumar1301 Nov 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Jira/Api/Client/CurlClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@

class CurlClient implements ClientInterface
{
/**
* Default timeout for CURL requests
*
* @var int seconds
*/
protected $timeout = 10;

/**
* create a traditional php client
Expand Down Expand Up @@ -93,6 +99,9 @@ public function sendRequest(
curl_setopt($curl, CURLOPT_USERPWD, sprintf('%s:%s', $credential->getId(), $credential->getPassword()));
}

if (is_numeric($this->timeout)) {
curl_setopt($curl, CURLOPT_TIMEOUT, $this->timeout);
}
curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, false);
curl_setopt($curl, CURLOPT_SSL_VERIFYHOST, 0);
curl_setopt($curl, CURLOPT_VERBOSE, $debug);
Expand Down
4 changes: 4 additions & 0 deletions tests/Jira/Api/Client/CurlClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,8 @@ protected function createClient()
return new CurlClient();
}

protected function testTimeout()
{
return new CurlClient();
}
}