This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Implements mir-validator, mir consensus and decouples storage #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
adlrocha
commented
Oct 11, 2022
dnkolegov
suggested changes
Oct 11, 2022
Comment on lines
+113
to
+116
| sm.NextBatch <- &Batch{ | ||
| Messages: msgs, | ||
| Validators: maputil.GetSortedKeys(sm.memberships[sm.currentEpoch]), | ||
| } |
There was a problem hiding this comment.
Once snapshots are supported, this will need to happen synchronously. How hard would it be to forego the channel completely and do right here what the mine function does on reading from that channel?
In fact, maybe we could get rid of more of these channels and handle the functionality right in the state manager...
|
After the internal review, closing in favor of filecoin-project/lotus#9492 targeting lotus |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
This PR integrates the Mir framework and implements a pBFT consensus algorithm over Mir. Mir is implemented as an alternative consensus algorithm for Lotus. In order to run Lotus with Mir, a new build parameter
build.Consensushas been provided.This PR includes:
chain/consensus/mirof Mir as a new consensus interface.mir-validatorprocess that implements all the mining and block producing logic for Mir.make mir-validatorcan be used to compile the process. This process is responsible for ordering new transactions and proposing new blocks to the network.build/params_buildernet.go) and a newbuild.Consensusflag used to determine the type of consensus to use. Using the Mir consensus disables the block production andwinningPoStprocess fromlotus-minerand forces the use of fake randomness forwindowPoSt.lotus-minercan still be used (and run) in a Mir Lotus network for storage-specific features (on boarding storage, starting storage and retrieval deals, markets, etc.).What's next?
We currently don't support the ability for other full nodes in the network to sync with a Mir network. Only validators running the consensus algorithm get new blocks. The next PR will include the syncing protocol (implementing #4)