feat(vllm): route RL controls through sidecar - #9
Draft
connorcarpenter15 wants to merge 5 commits into
Draft
Conversation
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vllm.ControlgRPC API instead of a development HTTP admin server./engine/*boundary.dyn://<namespace>.<component>.rl, including safe endpoint shutdown and discovery unregister/register ordering around pause, sleep, resume, and wake operations.Dependencies and overlap
7f3ab290464ac319e867b0d011d11dd6b2ff37f4.mainand includes the four commits from ai-dynamo/dynamo#12734 because the split native Control/Inference protocol is a prerequisite. Once that PR merges, GitHub should reduce this PR to the RL-specific diff.Validation
cargo fmt --all -- --check— passed.cargo check -p dynamo-vllm-sidecar -p dynamo-backend-common -p dynamo-vllm-mocker -p dynamo-trtllm-sidecar -p dynamo-mocker-backend— passed.cargo check --manifest-path lib/bindings/python/Cargo.toml— passed.cargo clippy -p dynamo-vllm-sidecar -p dynamo-backend-common -p dynamo-vllm-mocker -p dynamo-trtllm-sidecar -p dynamo-mocker-backend --all-targets -- -D warnings— passed.cargo test -p dynamo-vllm-sidecar rl_engine_routes_preserve_lifecycle_payloads_and_version -- --nocapture— passed, 1 test.cargo test -p dynamo-vllm-sidecar aggregated_generation_converts_request_stream_and_usage -- --nocapture— passed, 1 test.cargo test -p dynamo-backend-common routes_request_describes_the_worker_engine_surface -- --nocapture— passed, 1 test.cargo test -p dynamo-backend-common engine_control_policy_wraps_discovery_mutating_controls -- --nocapture— passed, 1 test.Not run
AI assistance disclosure
This implementation was prepared with OpenAI Codex assistance and requires human review before merge.