Enforce discard limits #606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
commented
Oct 11, 2023
| return errorf(CodeUnknown, "read enveloped message: %w", err) | ||
| } | ||
| return errorf(CodeResourceExhausted, "message size %d is larger than configured max %d", size, r.readMaxBytes) | ||
| src := io.LimitReader(r.reader, int64(size)) |
There was a problem hiding this comment.
For grpc-web tests I've limited this to the message payload. We discard the message but not the body trailers. Otherwise the count is incorrect. But maybe this defeats the purpose of the discard?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the correct solution but raising as a PR to get feedback. Currently enveloped messages can cause a large discard call as if the size is above the message size, which is above the the discard limit, then we always discard the next N bytes which could be 4Gb (max uint32).
Connect clients will discard when they've read as much input as the max message size, plus the discard limit.
Should the discard size be greater than the message size? For enveloped payloads should we discard the message limit? And for connect payloads should we count the message size read into the discard limit?
Another option could be to move the discard calls to occur after the error return, try discard for TCP reuse as a cleanup routine.