Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
266 changes: 221 additions & 45 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@
"@biomejs/biome": "^1.9.4",
"@bufbuild/license-header": "^0.0.4",
"turbo": "^2.5.5",
"typescript": "5.8.3"
"typescript": "^5.9.2"
}
}
2 changes: 1 addition & 1 deletion packages/connect-cloudflare/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint": "biome lint --error-on-warnings"
},
"dependencies": {
"@bufbuild/protobuf": "^2.2.0",
"@bufbuild/protobuf": "^2.7.0",
"@connectrpc/connect": "2.0.4",
"@connectrpc/connect-node": "2.0.4"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/connect-conformance/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@
"attw": "attw --pack"
},
"dependencies": {
"@bufbuild/protobuf": "^2.6.3",
"@bufbuild/protobuf": "^2.7.0",
"@connectrpc/connect": "2.0.4",
"fflate": "^0.8.2",
"tar-stream": "^3.1.7"
},
"devDependencies": {
"@bufbuild/buf": "^1.56.0",
"@bufbuild/protoc-gen-es": "^2.6.3",
"@bufbuild/protoc-gen-es": "^2.7.0",
"@types/debug": "^4.1.12",
"@types/node-forge": "^1.3.13",
"@types/tar-stream": "^3.1.4"
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/connect-conformance/src/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export async function* readSizeDelimitedBuffers(
n.set(chunk, buffer.length);
return n;
}
let buffer = new Uint8Array(0);
let buffer: Uint8Array = new Uint8Array(0);
for await (const chunk of stream) {
buffer = append(buffer, chunk);
for (;;) {
Expand Down
2 changes: 1 addition & 1 deletion packages/connect-express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
},
"peerDependencies": {
"express": "^4.18.2 || ^5.0.1",
"@bufbuild/protobuf": "^2.2.0",
"@bufbuild/protobuf": "^2.7.0",
"@connectrpc/connect": "2.0.4",
"@connectrpc/connect-node": "2.0.4"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/connect-fastify/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@connectrpc/connect-node": "2.0.4"
},
"peerDependencies": {
"@bufbuild/protobuf": "^2.2.0",
"@bufbuild/protobuf": "^2.7.0",
"fastify": "^4.22.1 || ^5.1.0",
"@connectrpc/connect": "2.0.4",
"@connectrpc/connect-node": "2.0.4"
Expand Down
2 changes: 1 addition & 1 deletion packages/connect-next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"node": ">=20"
},
"peerDependencies": {
"@bufbuild/protobuf": "^2.2.0",
"@bufbuild/protobuf": "^2.7.0",
"next": "^13.2.4 || ^14.2.5 || ^15.0.2",
"@connectrpc/connect": "2.0.4",
"@connectrpc/connect-node": "2.0.4"
Expand Down
3 changes: 2 additions & 1 deletion packages/connect-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@
"node": ">=20"
},
"peerDependencies": {
"@bufbuild/protobuf": "^2.2.0",
"@bufbuild/protobuf": "^2.7.0",
"@connectrpc/connect": "2.0.4"
},
"devDependencies": {
"@types/node": "^24.2.1",
"@connectrpc/connect-conformance": "^2.0.4",
"@types/jasmine": "^5.1.8",
"jasmine": "^5.9.0"
Expand Down
39 changes: 27 additions & 12 deletions packages/connect-node/src/compression.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,19 @@ const brotliDecompress = promisify(zlib.brotliDecompress);
export const compressionGzip: Compression = {
name: "gzip",
compress(bytes) {
return gzip(bytes, {});
return asUint8ArrayArrayBuffer(gzip(bytes, {}));
},
decompress(bytes, readMaxBytes) {
if (bytes.length == 0) {
return Promise.resolve(new Uint8Array(0));
}
return wrapZLibErrors(
gunzip(bytes, {
maxOutputLength: readMaxBytes,
}),
readMaxBytes,
return asUint8ArrayArrayBuffer(
wrapZLibErrors(
gunzip(bytes, {
maxOutputLength: readMaxBytes,
}),
readMaxBytes,
),
);
},
};
Expand All @@ -56,21 +58,34 @@ export const compressionGzip: Compression = {
export const compressionBrotli: Compression = {
name: "br",
compress(bytes) {
return brotliCompress(bytes, {});
return asUint8ArrayArrayBuffer(brotliCompress(bytes, {}));
},
decompress(bytes, readMaxBytes) {
if (bytes.length == 0) {
return Promise.resolve(new Uint8Array(0));
}
return wrapZLibErrors(
brotliDecompress(bytes, {
maxOutputLength: readMaxBytes,
}),
readMaxBytes,
return asUint8ArrayArrayBuffer(
wrapZLibErrors(
brotliDecompress(bytes, {
maxOutputLength: readMaxBytes,
}),
readMaxBytes,
),
);
},
};

function asUint8ArrayArrayBuffer(
bytes: Promise<Uint8Array>,
): Promise<Uint8Array<ArrayBuffer>> {
return bytes.then((b) => {
if (b.buffer instanceof ArrayBuffer) {
return b as Uint8Array<ArrayBuffer>;
}
return new Uint8Array(b);
});
}

function wrapZLibErrors<T>(
promise: Promise<T>,
readMaxBytes: number,
Expand Down
8 changes: 4 additions & 4 deletions packages/connect-web-bench/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ usually do. We repeat this for an increasing number of RPCs.

| code generator | RPCs | bundle size | minified | compressed |
| -------------- | ---: | ----------: | --------: | ---------: |
| Connect-ES | 1 | 284,091 b | 180,106 b | 36,449 b |
| Connect-ES | 4 | 288,343 b | 183,208 b | 37,266 b |
| Connect-ES | 8 | 293,206 b | 187,639 b | 38,144 b |
| Connect-ES | 16 | 302,334 b | 195,266 b | 39,673 b |
| Connect-ES | 1 | 284,162 b | 180,111 b | 36,441 b |
| Connect-ES | 4 | 288,414 b | 183,213 b | 37,244 b |
| Connect-ES | 8 | 293,277 b | 187,644 b | 38,156 b |
| Connect-ES | 16 | 302,405 b | 195,271 b | 39,672 b |
| gRPC-Web | 1 | 876,563 b | 548,495 b | 52,300 b |
| gRPC-Web | 4 | 928,964 b | 580,477 b | 54,673 b |
| gRPC-Web | 8 | 1,004,833 b | 628,223 b | 57,118 b |
Expand Down
10 changes: 5 additions & 5 deletions packages/connect-web-bench/chart.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/connect-web-bench/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
},
"dependencies": {
"@bufbuild/buf": "^1.56.0",
"@bufbuild/protobuf": "^2.6.3",
"@bufbuild/protoc-gen-es": "^2.6.3",
"@bufbuild/protobuf": "^2.7.0",
"@bufbuild/protoc-gen-es": "^2.7.0",
"@connectrpc/connect-web": "2.0.4",
"@types/brotli": "^1.3.4",
"brotli": "^1.3.3",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading