V2: Require HTTP/2 for the gRPC transport #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
changed the title
timostamm
commented
Oct 16, 2024
Comment on lines
+26
to
+27
| // @ts-expect-error TS2353: Object literal may only specify known properties, and httpVersion does not exist in type GrpcTransportOptions | ||
| httpVersion: "2", |
There was a problem hiding this comment.
httpVersion cannot be specified for createGrpcTransport anymore. It always uses HTTP/2.
srikrsna-buf
approved these changes
Oct 17, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC implementations typically require HTTP/2, but the protocol itself does not. connect-es can run gRPC over HTTP 1.1, but that requires support for HTTP trailers end to end. This can be difficult to achieve and guarantee, and most other gRPC implementations do not support it, so we are disabling support for gRPC over HTTP 1.1 in version 2.
Closes #1258.