V2: Use Stream{Request|Response} types in interceptors for all streaming rpcs
#1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g rpcs Signed-off-by: Sri Krishna Paritala <[email protected]>
timostamm
reviewed
Sep 13, 2024
| @@ -140,7 +140,7 @@ export interface StreamResponse< | |||
| readonly message: AsyncIterable<MessageShape<O>>; | |||
| } | |||
|
|
|||
| interface RequestCommon<I extends DescMessage, O extends DescMessage> { | |||
| export interface RequestCommon<I extends DescMessage, O extends DescMessage> { | |||
There was a problem hiding this comment.
Nice clean up.
Can you mark the two new exports as @private? They are not exported in the package, but this makes it unmistakably clear that they shouldn't be.
Signed-off-by: Sri Krishna Paritala <[email protected]>
timostamm
approved these changes
Sep 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1 the server used more exact types in interceptors, for example
UnaryRequestfor server streaming rpcs. The client always used streaming variants. This is inconsistent and was unintended.This change unifies the behavior, now all streaming rpcs will use the
StreamRequestandStreamResponseon the server as well. This is breaking change.