Add GitHub action PR workflow #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connec
force-pushed
the
pr-workflow
branch
6 times, most recently
from
031bd17 to
1981941
Compare
The `pr` workflow triggers on pull requests against master and runs `clippy`, `test`, and `doc`. `RUST[DOC]FLAGS=-D warnings` is used to promote warnings to errors when supported.
This was being triggered by the derive for EnumSetType, which generates an item that triggers the lint. It wasn't seen until now due to [rust-lang/rust-clippy#4612][1], which was only fixed in Rust 1.52.0. [1]: rust-lang/rust-clippy#4612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a652d4b ci: Add pull request workflow
The
prworkflow triggers on pull requests against master and runsclippy,test, anddoc.RUST[DOC]FLAGS=-D warningsis used topromote warnings to errors when supported.
9c14a4f fix: Fix expl_impl_clone_on_copy lint
This was being triggered by the derive for EnumSetType, which generates
an item that triggers the lint. It wasn't seen until now due to
rust-lang/rust-clippy#4612, which was only fixed in Rust 1.52.0.