Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the merge of CatsGotMyTonge's fork of Ice (TinyMCE v4 changes) with the upstream master (NYTimes) #1

Merged
merged 26 commits into from
Mar 17, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
5ca6a39
Fix for Issue 55: Webkit cut is broken
Aug 23, 2013
3b8850c
re-built master for fix for Issue #55
Aug 23, 2013
3cc4482
manually remove icepastediv from tinyMCE document
Aug 27, 2013
a1b124c
[Bug fix] caret disappears when deleting while track change is hidden…
unknower Aug 29, 2013
b5df829
after build
unknower Aug 29, 2013
fa2d46a
Fix for same user delete
unknower Aug 29, 2013
3f8bd75
stop propagation of paste event
Sep 2, 2013
7b5fb7f
Fix for cursor jumping to beginning or end
unknower Sep 12, 2013
8d44a9c
Merge branch 'dev' of https://github.com/NYTimes/ice into dev
unknower Sep 12, 2013
b856af8
rebuilt after merging
unknower Sep 12, 2013
c747261
Fixed: moving around after deleting a word containing white space whi…
unknower Sep 18, 2013
f30d118
Make pasteDiv removal compatible with all the browsers
unknower Sep 19, 2013
3c7a805
Make pasteDiv removal compatible with older browsers
unknower Sep 19, 2013
9c8be69
[fix] Cursor jumps to top or bottom on deletes with track changes hid…
unknower Sep 25, 2013
9e8ff56
Added build version of the fix
unknower Sep 25, 2013
61801e2
separate editor initialization from finding track tags, needed for re…
johanneswilm Dec 4, 2013
92afbcc
merged in dev
delambo Dec 6, 2013
cda1d4d
updating master build after merge from dev
delambo Dec 6, 2013
2258350
preparing 0.5.0 release
delambo Dec 6, 2013
dd68945
better stated
delambo Dec 6, 2013
396a3f5
fixes #94; clean up indentation and style
delambo Dec 13, 2013
c7924e2
update readme
delambo Dec 13, 2013
d5c1760
updating master minified source
delambo Dec 13, 2013
337f993
focus before moving cursor after pasting; closes #99
delambo Feb 3, 2014
1eb5bd1
Merge branch 'master' of github.com:NYTimes/ice into dev
NullVoxPopuli Mar 17, 2014
c058e63
removed tinyMCE 3.5, replaced with v4. re-organized plugins to match …
NullVoxPopuli Mar 17, 2014
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
15 changes: 9 additions & 6 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ module.exports = function(grunt) {

uglify: {
options: {
beautify : {
ascii_only : true
} ,
preserveComments: false,
banner: '//\n' +
'// <%= pkg.name %> - v<%= pkg.version %>\n' +
Expand All @@ -64,7 +67,7 @@ module.exports = function(grunt) {
},
ice: {
files: {
'dist/ice.min.js': ['lib/rangy/rangy-core.js', 'src/polyfills.js', 'src/ice.js', 'src/dom.js', 'src/bookmark.js', 'src/selection.js', 'src/icePlugin.js', 'src/icePluginManager.js', 'src/plugins/IceAddTitlePlugin/IceAddTitlePlugin.js', 'src/plugins/IceCopyPastePlugin/IceCopyPastePlugin.js', 'src/plugins/IceSmartQuotesPlugin/IceSmartQuotesPlugin.js', 'src/plugins/IceEmdashPlugin/IceEmdashPlugin.js']
'dist/ice.min.js': ['dist/ice.js']
}
},
icemaster: {
Expand All @@ -76,17 +79,17 @@ module.exports = function(grunt) {
'//\n'
},
files: {
'ice-master.min.js': ['lib/rangy/rangy-core.js', 'src/polyfills.js', 'src/ice.js', 'src/dom.js', 'src/bookmark.js', 'src/selection.js', 'src/icePlugin.js', 'src/icePluginManager.js', 'src/plugins/IceAddTitlePlugin/IceAddTitlePlugin.js', 'src/plugins/IceCopyPastePlugin/IceCopyPastePlugin.js', 'src/plugins/IceSmartQuotesPlugin/IceSmartQuotesPlugin.js', 'src/plugins/IceEmdashPlugin/IceEmdashPlugin.js']
'ice-master.min.js': ['dist/ice.js']
}
},
tinyice: {
files: {
'dist/ice_editor_plugin.js': 'lib/tinymce/jscripts/tiny_mce/plugins/ice/editor_plugin.js'
'dist/ice_editor_plugin.js': 'lib/tinymce/js/tinymce/plugins/ice/plugin.min.js'
}
},
tinysr: {
files: {
'dist/sr_editor_plugin.js': 'lib/tinymce/jscripts/tiny_mce/plugins/icesearchreplace/editor_plugin.js'
'dist/sr_editor_plugin.js': 'lib/tinymce/js/tinymce/plugins/icesearchreplace/plugin.min.js'
}
}
},
Expand Down Expand Up @@ -125,7 +128,7 @@ module.exports = function(grunt) {

grunt.registerTask('test', ['connect', 'qunit']);

grunt.registerTask('build', ['clean:build', 'uglify:ice', 'uglify:icemaster', 'concat', 'compress:gz', 'cp', 'compress:zip']);
grunt.registerTask('build', ['clean:build', 'concat', 'uglify:ice', 'uglify:icemaster', 'compress:gz', 'cp', 'compress:zip']);

grunt.registerTask('cp', function() {
cpTinyDir('ice');
Expand All @@ -136,7 +139,7 @@ module.exports = function(grunt) {
});

var cpTinyDir = function(dir) {
grunt.file.recurse('lib/tinymce/jscripts/tiny_mce/plugins/' + dir + '/', function(abspath, rootdir, subdir, filename) {
grunt.file.recurse('lib/tinymce/js/tinymce/plugins/' + dir + '/', function(abspath, rootdir, subdir, filename) {
grunt.file.copy(rootdir + '/' + (subdir ? subdir + '/' : '') + filename,'dist/tinymce/plugins/' + dir + '/' + (subdir ? subdir + '/' : '') + '/' + filename);
});
};
Expand Down
25 changes: 15 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# ice.js

Ice is a track changes implementation, built in javascript, for anything that is `contenteditable` on the web. Conceived by the CMS Group at The New York Times, ice has been piloting successfully for articles written in the newsroom.
Ice is a track changes implementation, built in javascript, for anything that is `contenteditable` on the web. Conceived by the CMS Group at The New York Times, ice is powering the editor used for writing articles in the newsroom.

## Demo

[Check it out!](http://NYTimes.github.com/ice/demo/)
[Try it](http://NYTimes.github.com/ice/demo/)

## Download

[v0.4.2](http://nytimes.github.com/ice/downloads/ice_0.4.2.zip)
[v0.5.0](http://nytimes.github.com/ice/downloads/ice_0.5.0.zip)

## Features

Expand Down Expand Up @@ -111,17 +111,22 @@ Additional options:
```
***

**_Wordpress initialization_**
## Limitations/Dependencies

In testing - more to come soon.
- ice needs to be initialized after the DOM ready event fires.
- Wordpress support is limited. We need contribution from any willing WordPress developers.
- Browser support is limited to Firefox (5+) and Webkit browsers, and minimal support for IE8+.

***
## Changelog

## Limitations/Dependencies
### Master

- ice needs to be initialized after the DOM ready event fires.
- ice was originally created for the simple markup behind nytimes.com articles (`p`, `a`, `em`, `strong`). As such, it requires that all text editing takes place in a common root block element, and that there are no other blocks found in the editor. Any type of inline elements are ok, inside of the common root blocks.
- Unfortunately, we haven't been able to test this across all browsers and versions. We know that it tests well in modern Firefox (5+) and Webkit browsers, and "seems to work" in IE7+. We intend to do more testing and get a better idea about what ice can support across browsers.
- Fixes bug where Webkit browsers were throwing errors when the letter "v" was pressed.

### 0.5.0

- Fixes cut, copy, paste for Firefox and Webkit browsers.
- Fixes delete tracking in webkit browsers.

## License

Expand Down
2 changes: 1 addition & 1 deletion demo/demo.css
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,4 @@ a.mceButton16 img.mceIcon { width: 16px; height: 16px; padding: 2px;}

.ins .del img {
padding: 0px 3px;
}
}
92 changes: 0 additions & 92 deletions demo/index-mce4-requirejs.html

This file was deleted.

Loading