Adapts NetworkClient usage for KAFKA-6863. - #914
Merged
Colin Hicks (colinhicks) merged 1 commit intoOct 15, 2018
Merged
Conversation
Konstantine Karantasis (kkonstantine)
approved these changes
Oct 15, 2018
Konstantine Karantasis (kkonstantine)
left a comment
Konstantine Karantasis (kkonstantine)
left a comment
Member
There was a problem hiding this comment.
Thanks Colin Hicks (@colinhicks) !
LGTM
Colin Hicks (colinhicks)
deleted the
fix-network-client-usage-for-kafka-6863
branch
October 15, 2018 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-6863 (apache/kafka#4987) altered the
NetworkClientconstructor to require aClientDnsLookupvalue. This change fixes the usage in Schema Registry causing compilation errors when built against Apache Kafka trunk.