Skip to content

Conversation

aaddepalli7
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings June 11, 2025 18:02
@aaddepalli7 aaddepalli7 requested a review from a team as a code owner June 11, 2025 18:02
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SchemaRegistryCoordinator to pass the new optional rack ID argument in line with the Kafka GroupRebalanceConfig API change.

  • Adds a second Optional.empty() to the constructor call to fill the new rack ID parameter.
  • Aligns the coordinator instantiation with the updated Kafka client config signature.
Comments suppressed due to low confidence (1)

core/src/main/java/io/confluent/kafka/schemaregistry/leaderelector/kafka/SchemaRegistryCoordinator.java:84

  • There are no unit tests covering the new rack ID parameter behavior. Consider adding tests to ensure the coordinator handles both present and absent rack IDs correctly.
Optional.empty(),

Comment on lines 83 to +84
Optional.empty(),
Optional.empty(),
Copy link
Preview

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The duplicated Optional.empty() calls are ambiguous. Consider using named constants or inline comments to clarify which Optional.empty() corresponds to the group instance ID and which to the new rack ID parameter.

Suggested change
Optional.empty(),
Optional.empty(),
GROUP_INSTANCE_ID_EMPTY,
RACK_ID_EMPTY,

Copilot uses AI. Check for mistakes.

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (0.00% Estimated after merge)
  • Duplications No duplication information (2.00% Estimated after merge)

Project ID: schema-registry

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant