Add AvroConverter support for Decimal, Date, Time, and Timestamp logical types.#234
Merged
Merged
Conversation
Contributor
Author
|
Liquan Pei (@Ishiihara) Requires KAFKA-2622, but it's ready for review now. |
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
Author
|
Right, and of course the tests will fail since the PR builder doesn't have the other patch ready. Will retest when KAFKA-2622 is committed. |
Contributor
|
LGTM otherwise. |
Contributor
There was a problem hiding this comment.
Expected objectNode?
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Ewen Cheslack-Postava (ewencp)
added a commit
that referenced
this pull request
Oct 9, 2015
Add AvroConverter support for Decimal, Date, Time, and Timestamp logical types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.