KIP-606 MetricsContext#180
Merged
Merged
Conversation
Ryan P (rnpridgeon)
requested review from
Rigel Bezerra de Melo (rigelbm) and
Shailesh Panwar (srpanwar-confluent)
May 19, 2020 14:08
Contributor
Author
|
POM changes need to be backed out prior to merger. |
Contributor
Author
|
apache/kafka#8691 has been merged and this PR updated with the changes. I also removed the resource label constraints from the base RestMetricsContext as it felt a bit weird to leak a specific metrics reporters details into rest-utils. We will leak them into the Application implementations instead :p |
Rigel Bezerra de Melo (rigelbm)
approved these changes
Jun 3, 2020
Rigel Bezerra de Melo (rigelbm)
left a comment
Rigel Bezerra de Melo (rigelbm)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
…xt to reflect merged changes to AK
Ryan P (rnpridgeon)
force-pushed
the
KIP-606
branch
from
June 3, 2020 20:14
b0c7e48 to
b932ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
built on top of apache/kafka#8691. Will attempt to be diligent about keeping this PR in sync with the progress of 8691. A preliminary review would be nice though.