-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client cert callback to check if trusted certificate authorities match with client certificate chain #4900
Client cert callback to check if trusted certificate authorities match with client certificate chain #4900
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
9bfa41c
to
a81b168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the change
a81b168
to
7d147c1
Compare
7d147c1
to
7f71403
Compare
ec21967
to
7ec52aa
Compare
7f71403
to
4eaab30
Compare
6cf59f0
to
d64f4f8
Compare
4eaab30
to
1266043
Compare
d64f4f8
to
f24ba97
Compare
1266043
to
b962b62
Compare
2f92f9f
to
2af89bf
Compare
b962b62
to
fccb1a2
Compare
when no certificate is sent instead of the one received when it's sent but not trusted.
fccb1a2
to
6036fc5
Compare
…h with client certificate chain. Co-authored-by: trnguyencflt <[email protected]>
6036fc5
to
05f3979
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after local testing.
in Java this selection is happening in X509KeyManagerImpl.getAliases
The field that is checked is
certificate_authorities
extension in TLS 1.3, that was present inCertificateRequest
in previous versions in TLS and SSL.