-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for an infinite loop in cooperative sticky assignor #4800
Conversation
I can confirm this works :) I applied it via a patch in rdkafka-ruby and was not able to trigger it anymore. Thank you! |
Thank you @mensfeld ! Couldn't push it earlier because we're reviewing company flows after the incident that happened to public repositories earlier in the month. |
No worries. You motivated me to finally craft ability to patch librdkafka for rdkafka-ruby so now I can also expose the needed fork-protect APIs for MacOS. Thank you for all your hard work 🙏 |
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please rebase and we should be good to merge.
e6c8a1f
to
583dc56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!. We can add a test but I don't feel there is necessity of a test for this kind of bug.
@pranavrth I've been running a similar patch for this for weeks, I have specs in rdkafka-ruby and karafka. This solves it as I was able to reproduce it on my side in 100%. |
when potential topic partitions are less than currently assigned ones.
583dc56
to
993aa1e
Compare
@mensfeld - I was saying that we don't need a test for this kind of trivial bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!.
when potential topic partitions are less than number of members.
Closes #4783