Fix calls with empty list #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milindl
approved these changes
Oct 24, 2023
src/rdkafka_admin.c
Outdated
| rd_kafka_admin_result_new(rko_fanout); | ||
| /* Enqueue empty result on application queue, we're done. */ | ||
| rd_kafka_admin_result_enq(rko_fanout, rko_result); | ||
| goto err; |
There was a problem hiding this comment.
Nit: it's better to call rd_kafka_admin_common_worker_destroy and then let it follow the normal flow down rather than goto err as this is not an error (at least semantically it's not considered an error case now even if the code is the same)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DescribeTopics and ListOffsets should return an empty array if and empty array is passed as parameter.
Consistent with Java and user friendly for users using filter and map.