Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored tmpabuf and fixed an insufficient buffer allocation #4449

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Refactored tmpabuf and fixed an insufficient buffer allocation #4449

merged 3 commits into from
Sep 28, 2023

Conversation

emasab
Copy link
Collaborator

@emasab emasab commented Sep 27, 2023

Closes #4398

@emasab
tmpabuf refactor
8b311b8 
and fix for insufficient buffer allocation
@emasab
Add PR id and contribution
0a915f5
@emasab emasab marked this pull request as ready for review September 27, 2023 09:13
@emasab emasab changed the title Refactored tmpabuf refactor and fixed an insufficient buffer allocation Refactored tmpabuf and fixed an insufficient buffer allocation Sep 27, 2023
@emasab emasab mentioned this pull request Sep 27, 2023
Closed
milindl
milindl approved these changes Sep 27, 2023
View reviewed changes
src/rdkafka_buf.h Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@wolfchimneyrock
Copy link
Contributor

Thanks @emasab. I can confirm that this PR fixes #4398 for me.

If its possible, do you mind either:

  1. squashing all three commits together
  2. having two commits - only with just the code update, one with just the documentation update

that would make it easier for me to backport this.

@emasab
Copy link
Collaborator Author

emasab commented Sep 28, 2023 •
edited
Loading

Thank you @wolfchimneyrock.
Sure, I'll squash when merging.

@emasab emasab merged commit cca5e75 into master Sep 28, 2023
2 checks passed
@emasab emasab deleted the dev_tmpabuf_refactor_and_fix branch September 28, 2023 14:30
axelandersson added a commit to axelandersson/librdkafka that referenced this pull request Oct 5, 2023
@axelandersson
Merge remote-tracking branch 'upstream/master' into dev_system-ifdef
5d9fe39 
* upstream/master:
  librdkafka v2.3.0 (confluentinc#4455)
  Fix for idempotent producer fatal errors, triggered after a possibly persisted message state (confluentinc#4438)
  Move can_q_contain_fetched_msgs inside q_serve (confluentinc#4431)
  [KIP-580] Exponential Backoff with Mock Broker Changes to Automate Testing. (confluentinc#4422)
  Update only the mklove version of OpenSSL to 3.0.11 (confluentinc#4454)
  Permanent errors during offset validation should be retried (confluentinc#4447)
  Increased flexver request size for Metadata request to include topic_id size (confluentinc#4453)
  Fix loop of OffsetForLeaderEpoch requests on quick leader changes (confluentinc#4433)
  Fix for stored offsets not being committed if they lacked the leader epoch (confluentinc#4442)
  Add leader epoch to control messages (confluentinc#4434)
  Refactored tmpabuf and fixed an insufficient buffer allocation (confluentinc#4449)
  Work around KIP-700 restrictions for DescribeCluster [KIP-430]
  [admin] KIP-430: Add authorized operations to describe API
  Fix segfault if assignor state is NULL, (confluentinc#4381)
matoro added a commit to matoro/gentoo that referenced this pull request Jan 15, 2024
@matoro
dev-libs/librdkafka: fix tests on 32-bit
a0db718 
See: confluentinc/librdkafka#4449
Bug: https://bugs.gentoo.org/915433
Signed-off-by: Matoro Mahri <[email protected]>
@matoro matoro mentioned this pull request Jan 15, 2024
Closed
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Jan 17, 2024
@matoro @thesamesam
dev-libs/librdkafka: fix tests on 32-bit
5c76ded 
See: confluentinc/librdkafka#4449
Bug: https://bugs.gentoo.org/915433
Signed-off-by: Matoro Mahri <[email protected]>
Closes: #34826
Signed-off-by: Sam James <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milindl milindl milindl approved these changes

@pranavrth pranavrth Awaiting requested review from pranavrth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rd_kafka_topic_info_new_with_rack insufficient buffer allocation
3 participants
@emasab @wolfchimneyrock @milindl