cmake: Fix using absolute path in include directories#3329
Merged
Magnus Edenhill (edenhill) merged 1 commit intoconfluentinc:masterfrom Apr 6, 2021
Merged
cmake: Fix using absolute path in include directories#3329Magnus Edenhill (edenhill) merged 1 commit intoconfluentinc:masterfrom
Magnus Edenhill (edenhill) merged 1 commit intoconfluentinc:masterfrom
Conversation
* External library include directories were binded as public dependency. That causes absolute path rependency and It produces absolute paths and that crashs build on yocto.
Contributor
Contributor
Bill Rose (neptoess)
left a comment
Bill Rose (neptoess)
left a comment
There was a problem hiding this comment.
Looks good to me. Good catch Hasan MEN (@hmenn) .
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That causes absolute path rependency and It produces
absolute paths and that crashs build on yocto.
You can check this pr for additional information about crash: openembedded/meta-openembedded#324 and this https://errors.yoctoproject.org/Errors/Details/575207/