Skip to content

chore: add rocksdbjni as explicit dependency to config setter module #7262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Victoria Xia (vcrfxia) merged 1 commit into from
Mar 17, 2021
Merged

chore: add rocksdbjni as explicit dependency to config setter module #7262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ksqldb-rocksdb-config-setter/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@
<artifactId>kafka-streams</artifactId>
</dependency>

<dependency>
<groupId>org.rocksdb</groupId>
<artifactId>rocksdbjni</artifactId>
<version>5.18.4</version>

@stevenpyzhang Steven Zhang (stevenpyzhang) Mar 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we could put this version number in the properties section in the ksql parent pom

@vcrfxia Victoria Xia (vcrfxia) Mar 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd agree but I don't feel strongly in this case since ksqlDB shouldn't be in the business of interacting with RocksDB directly (we should be going through Streams APIs for that) which means this dependency is specific to this config setter module.

OTOH, it's very little effort to move it and maybe we'll add more special modules later. I'll move it. Looks like we're going to try to get the transitive dependency put back in Streams so users don't have to keep their rocksdb versions in sync, which means this PR will likely get backed out so I'm going to leave it as is rather than restarting the build with a new commit.

</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down