chore: partial fix to stop ksql trimming trailing zeros from decimals#4711
Merged
Andy Coates (big-andy-coates) merged 6 commits intoMar 9, 2020
Merged
Conversation
partial fix for: confluentinc#4710 Remaining work needs a fix in Connect. Then to enable tests in KSQL.
Almog Gavra (agavra)
approved these changes
Mar 5, 2020
Almog Gavra (agavra)
left a comment
Almog Gavra (agavra)
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the fix Andy Coates (@big-andy-coates) :)
add some tests to remind us to finish this work off once Connect fixed
Add client test to ensure client doesn't strip those trailing zeros.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
partial fix for: #4710
Remaining work needs a fix in Connect (apache/kafka#8230). Then to enable tests in KSQL.
Testing done
Unit and QTT tests added.
Reviewer checklist