Re-apply KIP-460 changes#2904
Closed
Apurva Mehta (apurvam) wants to merge 2 commits into
Closed
Conversation
reapply confluentinc#2896 This reverts commit 437c145.
Almog Gavra (agavra)
approved these changes
May 31, 2019
Victoria Xia (vcrfxia)
approved these changes
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that the upstream changes for KIP-460 have been merged, we need to reapply #2896
This reverts commit 437c145.
Testing done
PR builder should pass
Reviewer checklist