Skip to content

Confluent: Sync AK/3.0 to CCS/3.0 up to 14 sep 2022 - #798

Merged
Manikumar Reddy (omkreddy) merged 17 commits into
3.0from
sync-3.0-14-SEP-2022
Sep 15, 2022
Merged

Confluent: Sync AK/3.0 to CCS/3.0 up to 14 sep 2022#798
Manikumar Reddy (omkreddy) merged 17 commits into
3.0from
sync-3.0-14-SEP-2022

Conversation

@fmin

Copy link
Copy Markdown

Notable merge conflict.

  • netty version: ccs upgraded to 4.1.79 while AK upgraded to 4.1.78 from previous version. Stick to 4.1.79
  • Jackson version upgrade : ccs upgrade to 2.13.2 with a specific JacksonDataBind version. AK upgrade to 2.13.3. 2.13.0+ should be good for CCV fix. Stick with current ccs version.
  • Upgrader.htm: Idempotence for producer is still considered disabled on upgrade_301_notable section. CCS disabled this feature for 301 release. AK has some wording change in this section. We keep status for 3.0.1 no change.

Commits:
* apache-kafka/3.0: (15 commits)
MINOR: Update 3.0 branch version to 3.0.3-SNAPSHOT
Upgrade Netty and Jackson versions for CVE fixes [KAFKA-14044] (apache#12376)
Bump version to 3.0.2
KAFKA-10712; Update release scripts to Python3 (apache#11538)
MINOR: Update LICENSE-binary
MINOR: Update docs/upgrade.html
MINOR: Update version to 3.0.2
MINOR: Add configurable max receive size for SASL authentication requests
MINOR: Add more validation during KRPC deserialization
MINOR: Add note on IDEMPOTENT_WRITE ACL to notable changes (apache#12260)

When running our Connect system tests with JDK 10+, we hit the error 
    AttributeError: 'ClusterNode' object has no attribute 'version'
because util.py attempts to check the version variable for non-Kafka service objects.

Reviewers: Konstantine Karantasis <k.karantasis@gmail.com>
…s log message (apache#12201)

Minor change to use ' and not LEFT SINGLE QUOTATION MARK in this log message, as it's the only place we are using such a quote and it can break ingestion pipelines

Reviewers: Kvicii <Karonazaba@gmail.com>, Divij Vaidya <diviv@amazon.com>, Konstantine Karantasis <k.karantasis@gmail.com>
…#12371)

The NPE causes the kraft controller to be in an inconsistent state. 

Reviewers: Jason Gustafson <jason@confluent.io>
… the offset map (apache#12390)

When cleaning a topic with transactional data, if the keys used in the user data happen to conflict with the keys in the transaction markers, it is possible for the markers to get removed before the corresponding data from the transaction is removed. This results in a hanging transaction or the loss of the transaction's atomicity since it would effectively get bundled into the next transaction in the log. Currently control records are excluded when building the offset map, but not when doing the cleaning. This patch fixes the problem by checking for control batches in the `shouldRetainRecord` callback.

Reviewers: Jun Rao <junrao@gmail.com>
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Aaron Freeland <afreeland@gmail.com>
)

Update notable changes documentation to mention requiring IDEMPOTENT_WRITE permission
when producing messages with default/idempotent configuration and broker version lower than
2.8.0.

Reviewers: Ismael Juma <ismael@juma.me.uk>, Luke Chen <showuon@gmail.com>
When deserializing KRPC (which is used for RPCs sent to Kafka, Kafka Metadata records, and some
other things), check that we have at least N bytes remaining before allocating an array of size N.

Remove DataInputStreamReadable since it was hard to make this class aware of how many bytes were
remaining. Instead, when reading an individual record in the Raft layer, simply create a
ByteBufferAccessor with a ByteBuffer containing just the bytes we're interested in.

Add SimpleArraysMessageTest and ByteBufferAccessorTest. Also add some additional tests in
RequestResponseTest.

Reviewers: Tom Bentley <tbentley@redhat.com>, Mickael Maison <mickael.maison@gmail.com>, Colin McCabe <colin@cmccabe.xyz>

Co-authored-by: Colin McCabe <colin@cmccabe.xyz>
Co-authored-by: Manikumar Reddy <manikumar.reddy@gmail.com>
Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
…ests

This adds a new configuration `sasl.server.max.receive.size` that sets the maximum receive size for requests before and during authentication.

Reviewers: Tom Bentley <tbentley@redhat.com>, Mickael Maison <mickael.maison@gmail.com>

Co-authored-by: Manikumar Reddy <manikumar.reddy@gmail.com>
Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
Reviewers: Mickael Maison <mickael.maison@gmail.com>
…2022

* apache-kafka/3.0: (15 commits)
  MINOR: Update 3.0 branch version to 3.0.3-SNAPSHOT
  Upgrade Netty and Jackson versions for CVE fixes [KAFKA-14044] (apache#12376)
  Bump version to 3.0.2
  KAFKA-10712; Update release scripts to Python3 (apache#11538)
  MINOR: Update LICENSE-binary
  MINOR: Update docs/upgrade.html
  MINOR: Update version to 3.0.2
  MINOR: Add configurable max receive size for SASL authentication requests
  MINOR: Add more validation during KRPC deserialization
  MINOR: Add note on IDEMPOTENT_WRITE ACL to notable changes (apache#12260)
  ...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omkreddy
Manikumar Reddy (omkreddy) deleted the sync-3.0-14-SEP-2022 branch September 15, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.