emit final sw fix - #785
Closed
Hao Li (lihaosky) wants to merge 2 commits into
Closed
Conversation
…disable cache for emit final sliding window (apache#12370) 1. Added more unit test for RocksDBTimeOrderedSessionStore and RocksDBTimeOrderedSessionSegmentedBytesStore 2. Disable cache for sliding window if emit strategy is ON_WINDOW_CLOSE Reviewers: Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
Enable index for sliding window emit final case as it's faster to fetch windows for particular key Reviewers: Guozhang Wang <wangguoz@gmail.com>
Guozhang Wang (guozhangwang)
approved these changes
Aug 18, 2022
Guozhang Wang (guozhangwang)
left a comment
Guozhang Wang (guozhangwang)
left a comment
There was a problem hiding this comment.
LGTM! Thanks Hao Li (@lihaosky)
Member
Author
|
Guozhang Wang (@guozhangwang) pointed out we don't have sliding window in ksqlDB yet so this is not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Major changes are disabling cache for sliding window and enable index for it. Other changes are tests and name refactor.
release branch hotfixes doesn't build, we just build from release stabilization job