Added an InMemoryLRUCacheStore and KeyValueStore unit test framework#75
Closed
Randall Hauch (rhauch) wants to merge 5 commits into
Closed
Added an InMemoryLRUCacheStore and KeyValueStore unit test framework#75Randall Hauch (rhauch) wants to merge 5 commits into
Randall Hauch (rhauch) wants to merge 5 commits into
Conversation
…nt directory if missing
… new RecordCollectorSupplier interface
…rt removes from the inner store. Also added test framework and unit tests for existing KeyValueStore implementations.
Author
|
Superseded by KAFKA-2594 and the new PR apache#256. |
José Armando García Sancio (jsancio)
pushed a commit
that referenced
this pull request
Sep 13, 2019
* chore(Dockerfile): update cc-base to v2.3.0 * remove mk-include * Squashed 'mk-include/' content from commit c8af747e3 git-subtree-dir: mk-include git-subtree-split: c8af747e3f7d9f5adfc6833afbf2325dfa9802ac * CONFLUENT: update cc-base, fix Makefile, update mk-include * Squashed 'mk-include/' changes from c8af747e3..3dc75ba14 3dc75ba14 feature(semver): add VERSION_POST variable, make branch overridable git-subtree-dir: mk-include git-subtree-split: 3dc75ba14e9065059e7cd826674e4dfca5f732fb * remove unused Makefile variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new
InMemoryLRUCacheStoreand changedMeteredKeyValueStoreto support recording removes initiated via the inner store. Also added test framework and unit tests for existingKeyValueStoreimplementations.Two smaller changes were made in separate commits, and these really could be useful whether or not the
InMemoryLRUCacheStoreis accepted:MeteredKeyValueStore's dependency onProcessorContextImplvia newRecordCollector.Supplierinterface. This allows otherProcessorContextimplementations (usually some form of mock implementations used in tests) to be usable with key value stores that extendMeteredKeyValueStore.This PR depends on several changes made in PR #74. If preferred, I can rebase this PR when #74 is accepted and merged.