Pick hotfixes#722
Merged
Walker Carlson (wcarlson5) merged 3 commits intoJun 9, 2022
Merged
Conversation
…fer.max.bytes" (apache#11796) Implements KIP-770 Reviewers: Guozhang Wang <wangguoz@gmail.com> (cherry picked from commit 0924fd3)
…12235) Implementation of KIP-846: Source/sink node metrics for Consumed/Produced throughput in Streams Adds the following INFO topic-level metrics for the total bytes/records consumed and produced: bytes-consumed-total records-consumed-total bytes-produced-total records-produced-total Reviewers: Kvicii <Karonazaba@gmail.com>, Guozhang Wang <guozhang@apache.org>, Bruno Cadonna <cadonna@apache.org>
Walker Carlson (wcarlson5)
requested a review
from A. Sophie Blee-Goldman (ableegoldman)
June 7, 2022 20:14
Ismael Juma (ijuma)
approved these changes
Jun 7, 2022
Ismael Juma (ijuma)
left a comment
Ismael Juma (ijuma)
left a comment
Member
There was a problem hiding this comment.
LGTM for the non streams code, I'll leave it to someone else to review the latter.
A. Sophie Blee-Goldman (ableegoldman)
left a comment
A. Sophie Blee-Goldman (ableegoldman)
left a comment
There was a problem hiding this comment.
Walker Carlson (@wcarlson5) were there any conflicts in Streams code/can you point me to where exactly in the file/code they occurred so I can just take a look at that and don't have to go through all of almost 3000 LOC... 😬
(cherry picked from commit ad18b43)
Author
|
A. Sophie Blee-Goldman (@ableegoldman) There were no conflicts after I cherrypicked the second PR |
Ismael Juma (ijuma)
approved these changes
Jun 9, 2022
Arvind Thirunarayanan (arvindth)
approved these changes
Jun 9, 2022
Arvind Thirunarayanan (arvindth)
left a comment
Arvind Thirunarayanan (arvindth)
left a comment
Member
There was a problem hiding this comment.
Approved for the change in CODEOWNERS.
Walker Carlson (wcarlson5)
merged commit Jun 9, 2022
48abbf7
into
confluentinc:7.2.0-cc-docker-ksql.80-96-ccs.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick over 2 commits for ksql 0.26.1 hotfix
Committer Checklist (excluded from commit message)