MINOR: Backported changes to ClientUtils.resolve tests to 2.4 - #414
Merged
Conversation
|
Justine Olshan (@jolshan) - given that there are 2 clean test runs in terms of test failures and that failures are related to downstream builds, i think we can merge this. (The only changes here are tests so i think downstream build issue is very unrelated). cc: Ismael Juma (@ijuma) David Arthur (@mumrah) - trying to get this cherry-picked here so we can get a 5.4.3 release going ASAP (since we were blocked on testing on the AK side). |
David Arthur (mumrah)
approved these changes
Oct 2, 2020
David Arthur (mumrah)
left a comment
David Arthur (mumrah)
left a comment
There was a problem hiding this comment.
Should be fine to merge this here first. Once we make the same change in AK, the next AK -> CCS merge will just not produce a diff for these particular changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests were fragile, so we made a temporary fix apache#9294
These changes need to be back-ported to previous versions.
The tests in question passed locally.