KAFKA-8586: Hot fix#239
Merged
Merged
Conversation
…ache#6993) Changed Connect's `WorkerSourceTask` to capture non-retriable exceptions from the `producer.send(...)` (e.g., authentication or authorization errors) and to fail the connector task when such an error is encountered. Modified the existing unit tests to verify this functionality. Note that most producer errors are retriable, and Connect will (by default) set up each producer with 1 max in-flight message and infinite retries. This change only affects non-retriable errors. (cherry picked from commit 3aa9f99)
Magesh Nandakumar (mageshn)
requested review from
Chris Egerton (C0urante) and
Xin Xiang (xiangxin72)
November 20, 2019 19:47
Member
Author
|
Xin Xiang (@xiangxin72) can we get PR builder enabled for this? |
Chris Egerton (C0urante)
approved these changes
Nov 20, 2019
Chris Egerton (C0urante)
left a comment
Chris Egerton (C0urante)
left a comment
There was a problem hiding this comment.
LGTM. Would be nice if we could run the branch builder to verify but these changes mirror the code in AK/trunk almost exactly so if that's not possible I still believe this should be okay.
Xin Xiang (xiangxin72)
approved these changes
Nov 22, 2019
Xin Xiang (xiangxin72)
left a comment
Xin Xiang (xiangxin72)
left a comment
There was a problem hiding this comment.
looks like we don't have a way to do PR build for old branch. Let's merge this in and use the packaging job to verify then (gonna take 5 hours though)
Andrew Egelhofer (andrewegel)
pushed a commit
that referenced
this pull request
Nov 16, 2021
As we are stopping brokers in these tests, there is a timing issue where the TierTopicManager doesn't manage to create the tier topic and doesn't become ready in time to archive the segments we produce. By the time it tries to create the tier topic, there are not enough brokers for the replication factor, meaning that all tiering is blocked. Also improve logging when tier topic creation fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-8586: Fail source tasks when producers fail to send records
Changed Connect's
WorkerSourceTaskto capture non-retriable exceptions from theproducer.send(...)(e.g., authentication or authorization errors) and to fail the connector task when such an error is encountered. Modified the existing unit tests to verify this functionality.Note that most producer errors are retriable, and Connect will (by default) set up each producer with 1 max in-flight message and infinite retries. This change only affects non-retriable errors.
(cherry picked from commit 3aa9f99)
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)