Skip to content

disallow SinkNode.addChild() #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ymatsuda merged 1 commit into from
Aug 28, 2015
Merged

disallow SinkNode.addChild() #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stream/src/main/java/org/apache/kafka/streaming/processor/internals/ProcessorNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ public ProcessorNode(String name, Processor<K, V> processor) {
this.children = new ArrayList<>();
}

public String name() {
public final String name() {
return name;
}

public List<ProcessorNode<?, ?>> children() {
public final List<ProcessorNode<?, ?>> children() {
return children;
}

public final void addChild(ProcessorNode<?, ?> child) {
public void addChild(ProcessorNode<?, ?> child) {
children.add(child);
}

Expand Down
5 changes: 5 additions & 0 deletions stream/src/main/java/org/apache/kafka/streaming/processor/internals/SinkNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ public SinkNode(String name, String topic, Serializer<K> keySerializer, Serializ
this.valSerializer = valSerializer;
}

@Override
public void addChild(ProcessorNode<?, ?> child) {
throw new UnsupportedOperationException("sink node does not allow addChild");
}

@Override
public void init(ProcessorContext context) {
this.context = context;
Expand Down