Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert - to _ in Hive table names #24

Merged
merged 1 commit into from
May 25, 2017
Merged

Convert - to _ in Hive table names #24

merged 1 commit into from
May 25, 2017

Conversation

ewencp
Copy link
Contributor

@ewencp ewencp commented May 25, 2017

No description provided.

@ewencp ewencp requested a review from kkonstantine May 25, 2017 03:01
@ewencp
Copy link
Contributor Author

ewencp commented May 25, 2017

@kkonstantine This is needed for refactoring HDFS to use common because of - used in some test topic names (and was requested as a follow-up to replacing . with _ in confluentinc/kafka-connect-hdfs#164). I think this covers all the translations needed for valid Kafka topic names given the constraints on Hive table names.

kkonstantine
kkonstantine approved these changes May 25, 2017
View reviewed changes
Copy link
Member

@kkonstantine kkonstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A needle in the haystack. Thanks for spotting this!

@ewencp ewencp merged commit c322eeb into master May 25, 2017
@ewencp ewencp deleted the topics-with-dashes-hive branch May 25, 2017 03:39
@kkonstantine kkonstantine mentioned this pull request May 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkonstantine kkonstantine kkonstantine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewencp @kkonstantine