Handle common logical types that Copycat supports: Decimal, Date, Time, Timestamp.#11
Merged
Merged
Conversation
Contributor
Author
|
Liquan Pei (@Ishiihara) Small update to fill in Decimal, Date, Time, and Timestamp support. Depends on KAFKA-2622 so we shouldn't merge until that patch has landed, but it should be easy to review before that. I think this covers all the logical types we need to handle for now, but it'd be good if you could also scan through the remaining unimplemented ones while reviewing this and make sure I haven't missed anything important. I think all the remaining ones are kind of obscure. |
Contributor
There was a problem hiding this comment.
Do we need the full qualified name here?
Contributor
|
Left minor comments. Otherwise LGTM. |
Ewen Cheslack-Postava (ewencp)
added a commit
that referenced
this pull request
Oct 10, 2015
Handle common logical types that Copycat supports: Decimal, Date, Time, Timestamp.
Shikhar Bhushan (shikhar)
pushed a commit
that referenced
this pull request
Jul 26, 2016
… validation is now in place as well as column mapping in case all fields have been set to be included fixed the upserts tests actually using insert fixed the sqlite dialect for upsert
Sangeet Mishra (sangeet259)
added a commit
that referenced
this pull request
Aug 26, 2024
…ution add distributionManagement tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.