Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exactly-once should also work with custom partitioner #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Exactly-once should also work with custom partitioner #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/io/confluent/connect/hdfs/TopicPartitionWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,8 @@ private boolean shouldRotate(long now) {

private void readOffset() throws ConnectException {
try {
String path = FileUtils.topicDirectory(url, topicsDir, tp.topic());
String partitionedPath = partitioner.generatePartitionedPath(tp.topic(), "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better than current state, but technically incorrect as generatedPartitionedPath might require the partition to produce a working output.

String path = FileUtils.topicDirectory(url, topicsDir, partitionedPath);
CommittedFileFilter filter = new TopicPartitionCommittedFileFilter(tp);
FileStatus fileStatusWithMaxOffset = FileUtils.fileStatusWithMaxOffset(storage, new Path(path), filter);
if (fileStatusWithMaxOffset != null) {
Expand Down