Handle primitive types in AvroRecordWriterProvider. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rnpridgeon @confluentinc/connect |
|
This issue has been around for quite awhile, I targeted 3.0.x and we can merge up to 3.1.x, 3.2.x, and master. |
kkonstantine
approved these changes
Feb 27, 2017
| long size = endOffset - startOffset + 1; | ||
| assertEquals(records.size(), size); | ||
| for (Object avroRecord : records) { | ||
| assertEquals(avroRecord, 12); |
There was a problem hiding this comment.
nit: Use the variable record instead? Rename it to something that stresses that it's just a static value?
There was a problem hiding this comment.
Ack, cleaned it up a bit.
This was referenced Feb 28, 2017
kkonstantine
added a commit
to kkonstantine/kafka-connect-storage-cloud
that referenced
this pull request
Oct 20, 2017
* Follows from: confluentinc/kafka-connect-hdfs#130 * Equivalent to: confluentinc/kafka-connect-hdfs#176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130