Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get context errors before tearing down test #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iso88592
Copy link

@iso88592 iso88592 commented Jun 6, 2018

On non-self test failures ducktape fails with `AttributeError: 'TestContext' object has no attribute 'services''

@ghost
Copy link

ghost commented Jun 6, 2018

It looks like @iso88592 hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@iso88592
Copy link
Author

iso88592 commented Jun 6, 2018

[clabot:check]

@ghost
Copy link

ghost commented Jun 6, 2018

@confluentinc It looks like @iso88592 just signed our Contributor License Agreement. 👍

Always at your service,

clabot

Copy link
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed this PR. Can you explain what non-self test failures are and why this is the right solution? the services attribute should be instantiated when the TestContext is initialized and wouldn't be cleared after that afaict.

Alternatively, how would we validate the updated behavior with a test?

@cla-assistant
Copy link

cla-assistant bot commented Aug 16, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Tibor Varkonyi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants