Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pep8 issues, add 2.15 and 2.16 sanity ignore #1558

Closed

Conversation

chynasan
Copy link

@chynasan chynasan commented Feb 19, 2024

Description

Updated spacing and corrected ansible-test sanity pep8 line-too-long errors in plugins/modules/kafka_connectors.py.
Added tests/sanity/ignore-2.15.txt and tests/sanity/ignore-2.16.txt to ensure ignores are up-to-date for versions tested against. Added an ignore to .ansible-lint for the molecule directory.

Included 2.14 changes from #1557

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran ansible-test sanity --docker default in venv for 2.15 and 2.16 to confirm pep8 and other logging is clean.

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Regards,
Ansible PE

@chynasan chynasan requested a review from a team as a code owner February 19, 2024 18:41
Copy link

cla-assistant bot commented Feb 19, 2024

CLA assistant check
All committers have signed the CLA.

@mansisinha
Copy link
Member

thanks @chynasan for bringing this up. We analysed and ran into some more sanity failures for the ansible versions. The sanity check fixes are now added in the latest versions. Closing the PR, thanks for the contribution!

@mansisinha mansisinha closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants