[KIP-396] List offsets implementation #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahajanadhitya
force-pushed
the
feature/AdminClient-ListOffsets
branch
from
ca13c4e to
7f2d748
Compare
|
|
mahajanadhitya
force-pushed
the
feature/AdminClient-ListOffsets
branch
from
c483723 to
767ea7e
Compare
emasab
changed the title
emasab
requested changes
Oct 13, 2023
and move them to a separate file
…fsets-changes [KIP-396] Address most of the PR comments
and _make_generic_futmap_result
pranavrth
requested changes
Oct 18, 2023
examples/get_watermark_offsets.py
Outdated
There was a problem hiding this comment.
Can we specify that the list_offsets example is present in adminapi.py?
There was a problem hiding this comment.
This is not in the changed files we can add a comment but do not think that is a great thing to do, list_offsets is admin api anybody can easily search it. So seems unnecessary.
emasab
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Thanks @mahajanadhitya @pranavrth . This looks good, let's wait for @pranavrth approval or for other comments.
philipnee
reviewed
Oct 19, 2023
examples/adminapi.py
Outdated
| topic_partition_offsets = {} | ||
| if len(args) < 1: | ||
| raise ValueError( | ||
| f"Invalid number of arguments for list offsets, expected at least 1, got {len(args)}") |
There was a problem hiding this comment.
it can only be 0 here no? len(args) < 1.
pranavrth
requested changes
Oct 23, 2023
an empty future dictionary. Increased test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.