KIP-320: Allow fetchers to detect #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and handle log truncation. Go changes
milindl
approved these changes
Mar 29, 2023
| Offset Offset | ||
| Metadata *string | ||
| Error error | ||
| LeaderEpoch *int32 |
There was a problem hiding this comment.
Can this just be int32, we can use a negative value (-1) similar to C case (as illustrated inif cLeaderEpoch >= 0).
We can change if it makes sense.
There was a problem hiding this comment.
Yes, just for the bindings I've followed the Java client that has an Option so I've put an optional field here, in Python and .NET
| @@ -77,6 +77,7 @@ type Message struct { | |||
| TimestampType TimestampType | |||
| Opaque interface{} | |||
| Headers []Header | |||
| LeaderEpoch *int32 // LeaderEpoch or nil if not available | |||
There was a problem hiding this comment.
Ditto, the thing about this not being a pointer here, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and handle log truncation. Go changes