Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nil pointer error on schemaregistry/serde/protobuf/protobuf.go #966

Closed
wants to merge 1 commit into from
Closed

fix nil pointer error on schemaregistry/serde/protobuf/protobuf.go #966

wants to merge 1 commit into from

Conversation

baganokodo2022
Copy link

an easy fix for potential nil pointer error.
we have hit nil pointer when desc.LoadMessageDescriptorForMessage() returns error.

@milindl
Copy link
Contributor

milindl commented May 15, 2023

Thanks a lot for your contribution @baganokodo2022!
We need to run the CI on it, which can only run on an internal branch. I've rebased this commit and created a PR for this here: #997. I will merge it as soon as the CI runs completely.

@milindl
Copy link
Contributor

milindl commented May 16, 2023

Thanks @baganokodo2022 , your change is merged into master.

@milindl milindl closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baganokodo2022 @milindl @xinyuliu-cb