Fix Url Parsing in Schema Registry #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While the new code seems fine to me, it seems we were deliberately going up one level due to the addition of base ( |
rayokota
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
LGTM. The original code came from https://github.com/confluentinc/confluent-kafka-go/pull/231/files#diff-569ea523a93f2963a2e9262bc3350ed168e8b330f0a3e9794057ee5eb3f00600R282 so I don't know if it was originally a bug or on purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#943 - Should fix this(Supports all schema-registry base urls which have existing path).