Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consumer] Ignore Seek() timeout #906

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

milindl
Copy link
Contributor

@milindl milindl commented Nov 30, 2022

Seek timeout is ignored and an infinite timeout is used instead. The method will block till fetcher state is updated and the seek is registered.

See #888.

@milindl milindl requested a review from a team November 30, 2022 10:04
CHANGELOG.md Outdated Show resolved Hide resolved
kafka/consumer.go Outdated Show resolved Hide resolved
kafka/consumer.go Outdated Show resolved Hide resolved
kafka/consumer.go Outdated Show resolved Hide resolved
Seek timeout is ignored and an infinite timeout is used instead.
The method will block till fetcher state is updated and the seek is
registered.

See confluentinc#888.
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milindl milindl merged commit d4543b7 into confluentinc:master Dec 1, 2022
PrasanthV454 pushed a commit that referenced this pull request Jan 12, 2023
Seek timeout is ignored and an infinite timeout is used instead.
The method will block till fetcher state is updated and the seek is
registered.

See #888.
PrasanthV454 pushed a commit that referenced this pull request Mar 17, 2023
Seek timeout is ignored and an infinite timeout is used instead.
The method will block till fetcher state is updated and the seek is
registered.

See #888.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants