Add IsTimeout method to Error #903
Conversation
There was a problem hiding this comment.
Add a CHANGELOG entry.
Also recommend updating one of the existing tests to use this too:
find a test that checks Code() == ..TimedOut,
in that test also add IsTimeout().
Why keep the old way? Because we want to make sure that we're not breaking existing functionality.
milindl
force-pushed
the
istimeout-conv
branch
from
471dc28
to
e0dc3df
Compare
| @@ -295,6 +295,9 @@ func TestConsumerAssignment(t *testing.T) { | |||
| if err.(Error).Code() != ErrTimedOut { | |||
| t.Errorf("Expected ReadMessage to fail with ErrTimedOut, not %v", err) | |||
| } | |||
| if !err.(Error).IsTimeout() { | |||
| t.Errorf("Expected ReadMessage to fail with a timeout error, not %v", err) | |||
There was a problem hiding this comment.
Maybe add a case for the success case too. E.g., from the TestConsumerAPIs dry-test (doesn't require a broker), you could call ReadMessage() with a low timeout and verify it is a timeout.
There was a problem hiding this comment.
I'm a bit unsure if I got this right since the case in TestConsumerAssignment is also a success case (ie it's a timeout).
I added a test in TestConsumerAPIs, hopefully that captures the intent of this comment.
This convenience method just checks if Error code is ErrTimedOut/ErrTimedOutQueue. Also modifies the example in README.md. Modifies the CHANGELOG.md.
milindl
force-pushed
the
istimeout-conv
branch
from
e0dc3df
to
30eed3a
Compare
This convenience method just checks if Error code is ErrTimedOut/ErrTimedOutQueue. Also modifies the example in README.md. Modifies the CHANGELOG.md.
This convenience method just checks if Error code is ErrTimedOut/ErrTimedOutQueue. Also modifies the example in README.md. Modifies the CHANGELOG.md.
This convenience method just checks if Error code is ErrTimedOut.
Also modifies the example in README.md.
See #846 (comment)