Go wrapper for rd_kafka_sasl_set_credentials #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
suggested changes
Oct 27, 2022
…/confluent-kafka-go into jvisser-sasl_set_credentials
edenhill
suggested changes
Nov 1, 2022
edenhill
suggested changes
Nov 8, 2022
|
close-reopened tro trigger CI |
edenhill
suggested changes
Nov 22, 2022
There was a problem hiding this comment.
We would need at least a dry test for this, just to make sure the API doesn't crash.
I recommend adding a call to the end of TestProducerAPIs() with a call to SetSaslCredentials():
https://github.com/confluentinc/confluent-kafka-go/blob/master/kafka/producer_test.go#L182
CHANGELOG.md
Outdated
|
|
||
| * Added SetSaslCredentials. This new method (on the Producer, Consumer, and | ||
| AdminClient) allows modifying the stored SASL PLAIN/SCRAM credentials that | ||
| will be used for subsequent (new) connections to a broker. |
There was a problem hiding this comment.
nit: weird indent, align with previous line.
PrasanthV454
pushed a commit
that referenced
this pull request
Jan 12, 2023
* Go wrapper for rd_kafka_sasl_set_credentials * Fixes after code review * Fixes after code review * Better description in CHANGELOG for this change. * Changes requested through code review
PrasanthV454
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Go wrapper for rd_kafka_sasl_set_credentials * Fixes after code review * Fixes after code review * Better description in CHANGELOG for this change. * Changes requested through code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Go wrapper for the rd_kafka_sasl_set_credentials call in librdkafka. Not much to it, since all of the hard work (locking etc) is done in the called C function.
Note: At the time of writing the underlying function is being added to librdkafka and might appear there in v1.9.4. This PR should only be merged after the new librdkafka version containing rd_kafka_sasl_set_credentials has been merged into librdkafka_vendor.
See confluentinc/librdkafka#4033