Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add offset type to NewOffset func #844

Closed
wants to merge 3 commits into from
Closed

add offset type to NewOffset func #844

wants to merge 3 commits into from

Conversation

jdockerty
Copy link
Contributor

@jdockerty jdockerty commented Aug 14, 2022 •
edited
Loading

Closes #778

Adding the ability to use a concrete Offset type with the NewOffset func, by extension this also enables it through the Offset.Set func.

An Offset is an int64 type in itself, so it can be returned as such.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jdockerty jdockerty changed the title add offset type to NewOffset add offset type to NewOffset func Aug 14, 2022
@PrasanthV454
Copy link
Member

Closing this and created #962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offset Set function should allow Offset as parameter.
3 participants
@jdockerty @CLAassistant @PrasanthV454