Added convenience method StoreMessage that calls StoreOffsets #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @finncolman, @confluentinc It looks like this brave person signed our Contributor License Agreement. 👍 Always at your service, clabot |
edenhill
suggested changes
Aug 18, 2021
edenhill
suggested changes
Sep 20, 2021
| // StoreMessage stores offset based on the provided message. | ||
| // This is a convenience method that uses StoreOffsets to do the actual work. | ||
| func (c *Consumer) StoreMessage(m *Message) (storedOffsets []TopicPartition, err error) { | ||
| if m.TopicPartition.Error != nil { |
There was a problem hiding this comment.
Maybe we should also make sure Offset is >= 0. You never know..
|
Thanks for your contribution! |
eran-levy
pushed a commit
to eran-levy/confluent-kafka-go
that referenced
this pull request
Apr 9, 2022
…olman, confluentinc#676) * Added convenience method StoreMessage that calls StoreOffsets * Added '.' at the end of the comment * Added Offset less than 0 check * Moved the check to the correct method Co-authored-by: Finn Colman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have "enable.auto.commit" set to true, but "enable.auto.offset.store" set to false then you need to call StoreOffsets after the consumer processing has completed, but at this stage you only have the message that was fetched, not the offsets.
This means that you end up writing code like this all over the place:
if m.TopicPartition.Error != nil { return nil, newErrorFromString(ErrInvalidArg, "Can't store errored message") } offsets := []TopicPartition{m.TopicPartition} offsets[0].Offset++ return c.StoreOffsets(offsets)This PR adds a convenience method StoreMessage that does this for you. This is similar to the CommitMessage method in that it simply gets the offset to store from the message.