Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate channel based consumer #546

Closed

Conversation

eran-levy
Copy link
Contributor

Fixes #545

There are still few tests such as the consumer_performance_test which are using the channel based consumer but I will create another issue to address that specifically.

@ghost
Copy link

ghost commented Oct 24, 2020

@confluentinc It looks like @eran-levy just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@eran-levy
Copy link
Contributor Author

it looks like there are some issues with the tests that arent relevant to this PR specifically, created this issue to address that #548

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Eran Levy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@eran-levy
Copy link
Contributor Author

@edenhill would you like to schedule this full deprecation for 1.9 as well?

@milindl
Copy link
Contributor

milindl commented May 15, 2023

Thanks for this PR! Closing this with #894 , we were able to deprecate channel based consumers.

@milindl milindl closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel based consumer not fully deprecated
3 participants