Added topic id to describeTopics Response #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
milindl
reviewed
Oct 3, 2023
kafka/testconf-example.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "Brokers": "mybroker or $BROKERS env", | |||
| "Brokers": "localhost:9092", | |||
kafka/generated_errors.go
Outdated
| @@ -1,7 +1,7 @@ | |||
| package kafka | |||
|
|
|||
| // Copyright 2016-2023 Confluent Inc. | |||
| // AUTOMATICALLY GENERATED ON 2023-07-12 11:45:05.970954589 +0200 CEST m=+0.000441527 USING librdkafka 2.2.0 | |||
| // AUTOMATICALLY GENERATED ON 2023-09-29 04:54:21.039467052 +0530 IST m=+0.006323752 USING librdkafka 2.2.0 | |||
There was a problem hiding this comment.
don't add this file to the change, we'll do it with the release
pranavrth
force-pushed
the
dev_add-topic-id-to-describe-group-response
branch
from
e7de1b1
to
34f496c
Compare
pranavrth
force-pushed
the
dev_add-topic-id-to-describe-group-response
branch
from
452f402
to
d7dc5af
Compare
milindl
reviewed
Oct 13, 2023
milindl
approved these changes
Oct 13, 2023
milindl
force-pushed
the
feature/kip430
branch
from
c97ee8b
to
755bc19
Compare
emasab
reviewed
Oct 20, 2023
kafka/integration_test.go
Outdated
| @@ -1420,6 +1420,7 @@ func (its *IntegrationTestSuite) TestAdminClient_DescribeTopics() { | |||
| "Expected correct error for nonexistent topic") | |||
|
|
|||
| topicDesc := topicDescs[0] | |||
| assert.NotNil(topicDesc.TopicID) | |||
There was a problem hiding this comment.
assert.NotNil asways returns true for structs according to this issue stretchr/testify#570
Suggest:
Suggested change
| assert.NotNil(topicDesc.TopicID) | |
| assert.NotZero(topicDesc.TopicID.GetLeastSignificantBits()) | |
| assert.NotZero(topicDesc.TopicID.GetMostSignificantBits()) | |
| assert.NotEmpty(topicDesc.TopicID.String()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.